<html>
<head><meta charset="utf-8"><title>Officially-minor changes and crater · t-lang · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/index.html">t-lang</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html">Officially-minor changes and crater</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="240500798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Officially-minor%20changes%20and%20crater/near/240500798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html#240500798">(May 27 2021 at 17:14)</a>:</h4>
<p><span class="user-mention silent" data-user-id="239881">Josh Triplett</span> <a href="#narrow/stream/268952-edition-2021/topic/reserved.20prefixes/near/240497399">said</a>:</p>
<blockquote>
<p>As well as making maintenance scale; a full crater run may not be an option forever.</p>
</blockquote>
<p>This comment reminded me of something that came to mind reading crater docs the other week.</p>
<p>We often run crater runs for changes that we're allowed to make, just out of caution.  Given that crater can run in a "top-N" mode, I wonder if it would make sense (for sustainability and just keeping the queue shorter) to have some policy like "if we're just looking at the impact of a new warning lint or similar, we'll only run on the top 10,000 crates".</p>
<p>That seems especially fine for things like lints where we can always tune things later, should feedback come in about some code pattern that wasn't considered.</p>



<a name="240509954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Officially-minor%20changes%20and%20crater/near/240509954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html#240509954">(May 27 2021 at 18:22)</a>:</h4>
<p>Interesting. That seems reasonable, assuming whatever mode we use accounts for popular dependencies too. (Which it almost certainly does through download counts.)</p>



<a name="240518705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Officially-minor%20changes%20and%20crater/near/240518705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html#240518705">(May 27 2021 at 19:27)</a>:</h4>
<p>my fear for top-N is that I expect that biases toward highly-maintained idiomatic code, missing the fringes of weird stuff that people may write</p>



<a name="240518762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Officially-minor%20changes%20and%20crater/near/240518762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html#240518762">(May 27 2021 at 19:27)</a>:</h4>
<p>we certainly don't want to regress top crates, but it's just not as interesting</p>



<a name="240526416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Officially-minor%20changes%20and%20crater/near/240526416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html#240526416">(May 27 2021 at 20:26)</a>:</h4>
<p>Perhaps we can have a sampling mechanism that's broader: top N crates, some sample of the rest, plus anything that's ever regressed before in any other crater run.</p>



<a name="240544653"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Officially-minor%20changes%20and%20crater/near/240544653" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html#240544653">(May 27 2021 at 23:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="138448">cuviper</span> <a href="#narrow/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater/near/240518705">said</a>:</p>
<blockquote>
<p>my fear for top-N is that I expect that biases toward highly-maintained idiomatic code, missing the fringes of weird stuff that people may write</p>
</blockquote>
<p>I think that might be ok, though, for things we're allowed to affect, especially when it's something we can roll back later, like lints.  I'm just thinking of things like "I don't really care that we added a bunch of warnings to Alex's repo of Advent of Code solutions from 2018".</p>
<p>Certainly for something like "can we make <code>k#foo</code> a hard error?" we'd need to look at everything still.</p>



<a name="240544903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/213817-t-lang/topic/Officially-minor%20changes%20and%20crater/near/240544903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/213817-t-lang/topic/Officially-minor.20changes.20and.20crater.html#240544903">(May 27 2021 at 23:32)</a>:</h4>
<p>Yeah, I think that's a valuable distinction. "sample the ecosystem to see if this would be invasively noisy and if we should fix a few popular crates first" is different than "exhaustively test the ecosystem to see if this soundness fix breaks things".</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>